-
Notifications
You must be signed in to change notification settings - Fork 47
Optimize CLI image building #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but it would be great if you could clarify the points above
- name: Set timezone | ||
uses: szenius/set-timezone@v1.0 | ||
with: | ||
timezoneLinux: "Europe/Moscow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need time zone here? And why is it set to Moscow?
|
||
RUN curl -H "Authorization: Bearer ${ACCESS_TOKEN}" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dockerfile looks much better
- uses: gradle/gradle-build-action@v2 | ||
with: | ||
gradle-version: 6.8 | ||
|
||
- name: Set project version | ||
run: echo "VERSION="$(date +%Y).$(date +%-m)"" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many double quotes look ambiguous
- name: Move cache | ||
run: | | ||
rm -rf /tmp/.buildx-cache | ||
mv /tmp/.buildx-cache-new /tmp/.buildx-cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the cache matter when we run on clean runner each time?
Description
CLI: publish image
is not a separate workflow anymore. This is a step inUTBot Java: build and run tests
workflow triggered only on push to the main branch.Fixes #648
Type of Change
How Has This Been Tested?
Automated Testing
Not applicable.
Manual Scenario
It was tested on fork.
Checklist (remove irrelevant options):
This is the author self-check list