Fixing the return type of outerHeight and outerWidth

[cdejemeppe]

According to the documentation of JQuery, starting from JQuery 3.0, both methods outerHeight and outerWidth return undefined when called on an empty set of elements.
Before version 3.0, it returned null.

For this reason, I propose to change the return type of both outerWidth and outerHeight to js.UndefOr[Double] instead of Double.

[Starzu]

Hi @cdejemeppe. You are right, I've overlooked this change.

In this wrapper we try to hide types from Scala.js, so you should remove these methods from JQuery trait and implement them in JQueryWrapper class around line 1147 of the same file.

Something like that:

/** Get the current computed height for the first element in the set of matched elements, including padding,
  * border, and optionally margin. Returns a number (without "px") representation of the value or undef
  * if called on an empty set of elements. <br/>
  * See: <a href="http://api.jquery.com/outerHeight/">jQuery Docs</a> */
def outerHeight(includeMargin: Boolean = false): Option[Double] =
  jquery.asInstanceOf[js.Dynamic].outerHeight(includeMargin).asInstanceOf[UndefOr[Double]].toOption

[cdejemeppe]

Hi @Starzu,

Thank you for the quick answer. I have made changes according to your suggestion.

[Starzu]

@cdejemeppe Could you also remove the original methods from JQuery trait?

[Starzu]

Thanks @cdejemeppe. I'll publish new version tommorow.