Skip to content

allow SPI display usage without CS pin #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 28, 2022

Conversation

seife
Copy link
Contributor

@seife seife commented Nov 29, 2022

If there is only one SPI device, the CS pin can be hardwired to ground. In that case, the CS pin setting should be ignored. Allow for that if CS is passed as "-1".

@marcelstoer
Copy link
Member

Thanks, makes sense. Could you please use {} around the single-line if blocks and add notes to the README about this enhancement?

If there is only one SPI device, the CS pin can be hardwired to ground.
In that case, the CS pin setting should be ignored. Allow for that if CS
is passed as "-1".
@seife
Copy link
Contributor Author

seife commented Nov 29, 2022

sure, I did initially not find the SPI section in the README due to mistyping my search :-)

@seife
Copy link
Contributor Author

seife commented Dec 27, 2022

JFTR: the README was fixed with the force-push from 2ea8d84 to e6b81a2 on Nov 29 already ;-)

@marcelstoer marcelstoer merged commit e2e063a into ThingPulse:master Dec 28, 2022
@seife seife deleted the spi_cs_optional branch December 28, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants