Moving _componentMap property inside the ReactJsonSchema class #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t its not shared between instances.
nlaffey
force-pushed
the
allow_multiple_instances_with_different_component_maps
branch
from
b376e51 to
2940df5
Compare
nlaffey
changed the title
nlaffey
commented
Jun 19, 2017
| @@ -34,7 +34,7 @@ var ReactJsonSchema = function () { | |||
| }, { | |||
| key: 'parseSubSchemas', | |||
| value: function parseSubSchemas() { | |||
| var subSchemas = arguments.length <= 0 || arguments[0] === undefined ? [] : arguments[0]; | |||
| var subSchemas = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : []; | |||
There was a problem hiding this comment.
Seems like this is compiling different? I assume this is ok and its just the result of the compiler version...
There was a problem hiding this comment.
Yeah, compiler probably updated to && for better performance (doesn't perform right hand evaluation if left hand fails, unlike ||).
eiof
approved these changes
Jun 19, 2017
elsif00
deleted the
allow_multiple_instances_with_different_component_maps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
_componentMapis aletthat sits outside of theReactJsonSchemaclass. When multiple instances of the class are created they unfortunately share the value of whichever instance set the value last. This PR moves the value inside of the class so that each instance gets to keep its own_componentMap.