Skip to content

feat: add an option to disable locals export #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2020
Merged

feat: add an option to disable locals export #24

merged 2 commits into from
May 18, 2020

Conversation

raphael-leger
Copy link
Contributor

Closes #23

@Obi-Dann
Copy link
Contributor

Obi-Dann commented May 5, 2020

I wonder if we should make disableLocalsExport true by default. From my understanding it's used very rarely. What do you think @raphael-leger ? cc @FinestV

@Obi-Dann
Copy link
Contributor

Obi-Dann commented May 5, 2020 •
edited
Loading

PS keen to merge this PR, it got a merge conflict with another PR you've submitted. Going to do a release once both PRs are merged

@raphael-leger
Copy link
Contributor Author

raphael-leger commented May 6, 2020 •
edited
Loading

To be honest, I do not know who use this locals thing.
To prevent a breaking change, I set disableLocalsExport to false.
It is possible to set disableLocalsExport to true, but it would introduce a breaking change to current users that do need this locals.

@Obi-Dann Obi-Dann merged commit 940d652 into TeamSupercell:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an option to not concatenate a type with a locals key
2 participants
@raphael-leger @Obi-Dann