Bullboard auth #11
Merged
Bullboard auth #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove unnecessary changes. I think you recompiled the node addon. |
|
How about now? |
|
You have deleted too much stuff, unstage those changes instead of deleting files. |
VidithM
force-pushed
the
bullboard-auth
branch
from
27b862e to
42045e3
Compare
|
This is not how it works. You should reset your commits and then stage only desired changes. |
|
Sorry, I am working on it. I'll comment when I get the right version |
VidithM
force-pushed
the
bullboard-auth
branch
from
42045e3 to
5ee0824
Compare
|
Ok, I think it should be good now? Let me know. |
SysSn13
requested changes
Sep 2, 2021
VidithM
force-pushed
the
bullboard-auth
branch
from
96b261e to
bb226f5
Compare
|
I also added a 404 page for invalid paths |
SysSn13
approved these changes
Sep 4, 2021
SysSn13
approved these changes
Sep 4, 2021
SysSn13
added a commit
that referenced
this pull request
Jan 30, 2024
* Added bull-board auth using passport.js * Minor changes * update .gitignore Co-authored-by: SysSn13 <sudesh18@iitg.ac.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #9. Now, whenever the background is running and we go to /bull-board, if we are not authenticated we are first redirected to a login page. The login credentials can be configured in .env.