Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

Update Homebrew CI Workflow #261

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Update Homebrew CI Workflow #261

merged 2 commits into from
Apr 26, 2021

Conversation

mattt
Copy link
Contributor

@mattt mattt commented Apr 26, 2021

The Homebrew continuous integration workflow added in #243 currently runs on every push to master as well as once per day. Running on pushes to master is probably too often, and it also causes build failures when pushing new releases.

This PR replaces the push event with a manual "workflow dispatch", which adds a button on GitHub.com to test it whenever we'd like. In combination with a scheduled smoke test, I think that should strike the right balance.

@mattt mattt requested a review from Lukas-Stuehrk April 26, 2021 16:29
Copy link
Member

@Lukas-Stuehrk Lukas-Stuehrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think this makes more sense than running on every push on master.

@mattt mattt merged commit 70d4afd into master Apr 26, 2021
@mattt mattt deleted the homebrew-smoketest branch April 26, 2021 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants