Skip to content

Establish this repo as a stand-alone package for ST4 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

FichteFoll
Copy link
Member

This MR contains changes to the README and deletes the YAML macros files because I find them cumbersome to work with and not worth it in the current state of the syntax. Furthermore, it gets rid of an external dependency.

Additional actions performed outside of this merge request:

  • The repo has been mirrored from https://github.com/vuejs/vue-syntax-highlight but not as a fork because I intend the two to go into different directions. This repo will focus on providing good syntax highlighting support for Vue while the original one can continue to maintain the tmLanguage syntax for Linguist.
  • The previous st4 branch is now main (also the default branch).
  • The old tmLanguage file will be installable for ST2 and 3 from prefixed tags, created from the new st2 branch (old master).
  • Corresponding tags will be created later.

I find maintaining both files more cumbersome than the boilerplate from
duplicate embeds and the two files have already deteriorated over time.
@deathaxe
Copy link
Member

Maybe we can re-use lang=... attribute specific contexts from https://github.com/corneliusio/svelte-sublime which recently removed yaml macros and introduced named contexts for each script language.

@FichteFoll
Copy link
Member Author

That sounds like a good idea. Feel free to add this in a separate PR. I have created some issues for useful things to consider from both the original repo and on my own that we could tackle at a later point.

@deathaxe
Copy link
Member

OK, will wait for this to be merged.

LGTM. btw.

@FichteFoll
Copy link
Member Author

Thanks for the review.

@FichteFoll FichteFoll merged commit 428d20a into main Nov 18, 2024
@FichteFoll FichteFoll deleted the feature/standalone branch November 18, 2024 15:00
deathaxe added a commit to deathaxe/package_control_channel that referenced this pull request Nov 21, 2024
This commit...

1. renames "Vue Syntax Highlight" package to "Vue"
2. retargets the package to SublimeText organization
   see: SublimeText/Vue#2
3. changes tag-prefixes from `st4-` to `<build>-`
4. adds another waypoint for ST4126+ releases with
   various backward compatibility only contexts removed.
@FichteFoll FichteFoll added this to the 5.0.0 milestone Nov 21, 2024
FichteFoll pushed a commit to wbond/package_control_channel that referenced this pull request Dec 8, 2024
This commit...

1. renames "Vue Syntax Highlight" package to "Vue"
2. retargets the package to SublimeText organization
   see: SublimeText/Vue#2
3. changes tag-prefixes from `st4-` to `<build>-`
4. adds another waypoint for ST4126+ releases with
   various backward compatibility only contexts removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants