Skip to content

Applied first batch of enhancements for 6.0 #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 25, 2022

Conversation

julian-cable
Copy link
Collaborator

Please review these enhancements for the upcoming October Release 6.0 of the style guide, to add previously missing guidance from the snippets.

Copy link
Collaborator

@daobrien daobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some updates required.


<!-- Added section about "either, or" -->
<formalpara id="either-or">
<title>Either, Or</title>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to do a better job with our titles. This will obviously be an ongoing task, but we need to avoid one-word titles and super brief titles like this one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


<!-- Added section about "following" -->
<formalpara id="following-noun">
<title>Following</title>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another title to update.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

<formalpara id="if-then">
<title>If, Then</title>
<para>
Follow an "if" statement with a "then" statement.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't make this a blanket rule. Maybe add "generally" or similar? (And review the title.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Do not use gender-specific pronouns in documentation, except to refer to a specific named user, such as in a case study. It is far less awkward to read a sentence that uses "they" and "their" rather than "he/she" and "his/hers". It is acceptable to use "they" to refer to one person, with a plural verb.
</para>
<para>
In most cases, when giving instructions, use the imperative mood or use "you". In more general explanations, you can use "the user" or "new users". Do not use "one" in place of "you" when writing technical documentation. Using "one" is far too formal. Do not use "it" to refer to a person.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In most cases, when giving instructions, use the imperative mood or use "you". In more general explanations, you can use "the user" or "new users". Do not use "one" in place of "you" when writing technical documentation. Using "one" is far too formal. Do not use "it" to refer to a person.
In most cases, when giving instructions, use the imperative mood or use "you". In more general explanations, you can use "users" or "new users". Do not use "one" in place of "you" when writing technical documentation. Using "one" is far too formal. Do not use "it" to refer to a person.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -946,6 +946,86 @@ Numbers (move from N entry) -->
</para>
</section>

<!-- Added section for "easy, simple" -->
<section id="easy">
<title>Avoiding "Easy"</title>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use punctuation or markup in titles. I also think that this is unsuitable as a section on its own, especially at this level. We need to take the design and layout of the book into account. This would possibly fit under "Avoiding Ambiguities".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved and fixed

Comment on lines 970 to 971
<entry> Mounting a device is relatively simple. </entry>
<entry> Identify the device for mounting, ensure that the mount point exists, and mount the device on the mount point. </entry>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see statement #2 as an improvement of statement #1. I think you could improve #1 by saying "Mounting a file system is straightforward." Statement #2 is about how to mount a file system. NB: Any device that you want to mount must have a file system on it. You could perhaps read the man page or even talk to Phil about an example if you want to improve further.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworked the example. The intent here is to avoid stating that the task is easy, and to focus instead on how to do it.

</tgroup>

</table>

<!-- Added section about use of relative pronoun "that" -->
<formalpara id="that">
<title>"That" in Clauses</title>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to remove punctuation in titles as we go.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment on lines +519 to +520
<entry> Divide the storage devices into smaller chunks to create a partition. </entry>
<entry> To create a partition, divide the storage devices into smaller chunks. </entry>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really an example of a condition. Conditions typically start with "if": "If X then Y." This example is reversing "Do X to achieve Y" to become "To achieve Y, do X."

I also think we need a better example. "Dividing storage devices into smaller chunks" could mean a variety of things, and not necessarily create partitions. Maybe have a look at https://docs.fedoraproject.org/en-US/quick-docs/creating-a-disk-partition-in-linux/
I think it'd be pretty easy to make up a "bad example" and then improve it using the commands and examples documented here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intent here was something other than an "if ... then" construction. I've removed the entry for now, and will think further about what to do.

Comment on lines 1016 to 1017
<entry> Remote users can connect to network resources simply by authenticating to their local machine. </entry>
<entry> Remote users can connect to network resources by authenticating to their local machine. </entry>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opportunity for more examples here? Are there exceptions? ("Modern hard drives can be very large.")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more examples. (I would be inclined not to provide an exception to allow "very"; I think that a better alternative could often be found, such as "Modern hard drives can be so large that ...".)

@@ -180,6 +183,70 @@
</tgroup>

</table>
<para>
For a lead-in sentence that introduces a list, use a complete sentence. A lead-in that is a sentence fragment is hard to translate into other languages.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For a lead-in sentence that introduces a list, use a complete sentence. A lead-in that is a sentence fragment is hard to translate into other languages.
For a lead-in sentence that introduces a list, use a complete sentence. A lead-in that is a sentence fragment can be difficult to translate into other languages.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Collaborator

@daobrien daobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things to look at, and a question I think you should put to Fernando about Kubernetes.

Comment on lines 553 to 554
<entry> Scale up by adding more resources, with more memory, CPU, disk space, or other resources. </entry>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have written "...resources, such as memory, CPUs, disk space, and so on." Memory is not countable, and neither is disk space, but CPU is a countable noun.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

<!-- Added section about use of relative pronoun "that" -->
<formalpara id="that">
<title>"That" in Clauses</title>
<title>That in Clauses</title>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without putting too fine a point on it, this is not a very exciting title. "That in Clauses"? I suggest reading the section a couple of times and a better title will probably reveal itself.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

<section id="redundant">
<title>Avoiding Redundant Words</title>
<para>
Avoid redundant words, such as "actually", "just", "really", "simply" and "very". They are filler words that add no value to a sentence.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to qualify this. Yes, sometimes they are redundant. Sometimes they are not. It depends on how they are used. E.g.,

  • "We are proud of our content, and with just cause."
  • "Why do you want to do this?" "Just because."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -986,6 +1030,56 @@ Numbers (move from N entry) -->
</listitem>

</varlistentry>
<!-- Added entry for "easy, simple" -->
<varlistentry id="easy">
<term> Avoiding "Easy" </term>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I don't think this title suits the content, and we shouldn't be using punctuation in titles.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment on lines 1062 to 1068
<entry> Kubernetes is an orchestration service that makes it easier to deploy, manage, and scale container-based applications across a cluster of container hosts. </entry>
<entry>
<para>
Option 1: Kubernetes is an orchestration service that deploys, manages, and scales container-based applications across a cluster of container hosts.
</para>
<para>
Option 2: Kubernetes is an orchestration service that makes it easier than manual container management to deploy, manage, and scale container-based applications across a cluster of container hosts.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please talk to Fernando about this one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated following feedback from Fernando.

<section id="pronouns-gender-references">
<title>Pronouns and Gender References</title>
<para>
Do not use gender-specific pronouns in documentation, except to refer to a specific named user, such as in a case study. It is far less awkward to read a sentence that uses "they" and "their" rather than "he/she" and "his/hers". It is acceptable to use "they" to refer to one person, with a plural verb.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "It is far less awkward to read..." how about "It is easier to read..."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor

@nmuller66 nmuller66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julian-cable I've left a couple of comments.

Copy link
Contributor

@nmuller66 nmuller66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julian-cable julian-cable merged commit a9b69e1 into dev Oct 25, 2022
@julian-cable julian-cable deleted the jcable/6.0-enhancements branch November 1, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment