Make sure failures in multiline CI steps are not swallowed. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, it is possible to have a passing CI job even though the build failed, e.g. https://github.com/dabrahams/CBORCoding/actions/runs/6806944368/job/18509010389#step:4:99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cause failures in CI to be reported
Checklist
Ensure that your
pull requesthas followed all the steps below:Proposed changes
Without this change, it is possible to have a passing CI job even though the build failed, e.g.
https://github.com/dabrahams/CBORCoding/actions/runs/6806944368/job/18509010389#step:4:99
And in fact you will see that this PR reveals 1 linting problem and 11 test failures on ubuntu-latest that were being ignored.