Fix exception when parsing with sliced Data #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data uses slices which may not start at 0. When a Data is supplied which does not start at 0, the first index previously used would throw a bad access exception. This happened for example with a Data value returns from CBOR previously. It does not per-se start with a slice at 0.
|
Hmm no idea why it is failing. I removed the whitespace already... |
roxiemobile-forks
added a commit
to roxiemobile-forks/CBORCoding
that referenced
this pull request
May 2, 2021
…when parsing with sliced Data".
roxiemobile-forks
added a commit
to roxiemobile-forks/CBORCoding
that referenced
this pull request
May 2, 2021
…when parsing with sliced Data".
|
@joskuijpers I pulled your commits and made a few additional updates to yours and merged it with PR #18 |
roxiemobile-forks
added a commit
to roxiemobile-forks/CBORCoding
that referenced
this pull request
Mar 21, 2022
…hen parsing with sliced Data".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Data input is used that has a slice started beyond 0, an exception was thrown because the parser tried to access index 0.
See for example https://stackoverflow.com/questions/54698947/swift-data-subdata-fails-with-exc-bad-instruction-code-exc-i386-invop-subcode for an explanation.
All that was needed to fix it was to start at
data.startIndexand finishes beforedata.endIndex.I also added a testcase that failed before my change and succeeds after my changes. The rest of the cases still run.