Drop support for php 5.4 and 5.5 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
- Coverage 90.4% 89.45% -0.96%
==========================================
Files 17 17
Lines 271 275 +4
==========================================
+ Hits 245 246 +1
- Misses 26 29 +3
Continue to review full report at Codecov.
|
xabbuh
reviewed
May 2, 2017
.travis.yml
Outdated
| env: SYMFONY_VERSION="2.7.*" | ||
| - php: 5.6 | ||
| env: SYMFONY_VERSION="2.8.*@dev" |
There was a problem hiding this comment.
I would keep 2.8 as it is an LTS release
There was a problem hiding this comment.
@xabbuh Yes, we should i will add this again tnx
Add travis for php 7.1 Changed symfony version to 2.7 and 3.2 Changed the single pipe | to double to be inline with the rest of the repositorie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details SimpleBus/message-bus#68