Skip to content

Add subscribers autowiring feature #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add subscribers autowiring feature #40

wants to merge 1 commit into from

Conversation

unkind
Copy link

@unkind unkind commented Jan 2, 2017

This is a draft of autowiring feature described in #39.

Some notes:

  • for consistency with regular subscribes_to, this feature doesn't explicitly disallows non-final events; one might think that if you type-hinted against an interface or abstract/inheritable event class, you'd also subscribe all the children, but that's not the case;
  • since event_name_resolver_strategy is a global flag, I couldn't find way to test feature in the SmokeTest, so it has separate test case.

Example of configuration:

services:
    send_email_verification_instructions_subscriber:
        class: Acme\SendEmailVerificationInstructionsSubscriber
        tags:
            - { name: event_subscriber_autowired }

@coveralls
Copy link

coveralls commented Jan 2, 2017

Coverage Status

Coverage decreased (-6.1%) to 83.382% when pulling 3391848 on unkind:feature-autowiring into 7879503 on SimpleBus:master.

@cmodijk
Copy link
Member

cmodijk commented Jun 12, 2017

I'm going close this in favor of #43 @unkind Tnx for your work and suggestions.

@cmodijk cmodijk closed this Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants