Type-generic zeromatrix for arraypartition #444
+21
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oscardssmith this is blocked by a version-specific inference failure. Could I get some help with that? I assume it's because of some v1.10 vs v1.11 difference in mapreduce inference. |
A function similar to what is implemented commit 2094a78 but for NamedArrayPartitions rather than ArrayPartitions. Tested privately to work with Implicit solvers in OrdinaryDiffEq.jl
NamedArrayPartition zeromatrix
| @@ -166,7 +166,7 @@ Base.:(==)(A::ArrayPartition, B::ArrayPartition) = A.x == B.x | |||
|
|
|||
| Base.map(f, A::ArrayPartition) = ArrayPartition(map(x -> map(f, x), A.x)) | |||
| function Base.mapreduce(f, op, A::ArrayPartition{T}; kwargs...) where {T} | |||
| mapreduce(f, op, (i for i in A); kwargs...) | |||
| mapreduce(x->mapreduce(f, op, x; kwargs...), op, (i for i in A.x); kwargs...) | |||
There was a problem hiding this comment.
I'm guessing this is probably the inference issue. Our mapreduce framework is rather baroque.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One part of SciML/OrdinaryDiffEq.jl#2703