Input component and Hydraulic changes #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bradcarman
commented
May 1, 2023
bradcarman
commented
- Input component that can now properly drive models from data. See: input component tutorial for more information
- Hydraulic/IsothermalCompressible now exports Tube instead of Pipe so as to not conflict with Base.Pipe
- Added Actuator component to Hydraulic library
added 11 commits
April 24, 2023 19:42
Codecov Report
@@ Coverage Diff @@
## main #163 +/- ##
==========================================
- Coverage 60.23% 59.61% -0.62%
==========================================
Files 40 41 +1
Lines 1818 2028 +210
==========================================
+ Hits 1095 1209 +114
- Misses 723 819 +96
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
YingboMa
approved these changes
May 1, 2023
baggepinnen
reviewed
May 2, 2023
There was a problem hiding this comment.
It's not completely clear to me what kind of input data this new Input component can handle, does the data have to be equidistantly sampled? I think the name Input might be slightly unfortunate since
inputis a keyword in modelica with a completely different meaning. We have a similar metadata field in MTK[input = true]which also has a different semantic meaning.- The functionality behind the
Inputcomponent appears to be limited to sampled data inputs only, and the sample rate must be equidistant?SampledDataInputmay be a more descriptive name.
Comment on lines
+497
to
+502
| if T isa Float16 | ||
| return NaN16 | ||
| elseif T isa Float32 | ||
| return NaN32 | ||
| elseif T isa Float64 | ||
| return NaN64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.