Skip to content

Add Translational library similar to MSL #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 19, 2023
Merged

Conversation

baggepinnen
Copy link
Contributor

This PR adds a version of the Mechanical.Translational that is more similar to the modelica versions than the two existing Mechanical.Translational and Mechanical.TranslationalPosition. There are several strong motivations for staying closer to the modelica equivalents:
The multibody library uses the Translational library, and any deviation increases the multibody implementation effort many fold, as well as making it much more likely that we introduce bugs in the process. A graphical user interface becomes similarly more difficult to implement when a translation step is required between the open standard and our implementation, for us to be able to reuse existing assets. Lastly, the burden on existing modelica users who want to transition increases if we change variable names and definitions in subtle ways, with no clear benefit.

This implementation is quite a bit lighter weight than the current TranslationalPosition due to making use of partial models in the same way modelica does.

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #151 (50da17d) into main (a8428c8) will decrease coverage by 3.81%.
The diff coverage is 1.78%.

❗ Current head 50da17d differs from pull request most recent head 8c6e16a. Consider uploading reports for the commit 8c6e16a to get more accurate results

@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   63.10%   59.29%   -3.81%     
==========================================
  Files          37       40       +3     
  Lines        1713     1823     +110     
==========================================
  Hits         1081     1081              
- Misses        632      742     +110     
Impacted Files Coverage Δ
src/Mechanical/Rotational/sources.jl 44.11% <0.00%> (-30.89%) ⬇️
src/Mechanical/TranslationalModelica/components.jl 0.00% <0.00%> (ø)
src/Mechanical/TranslationalModelica/sources.jl 0.00% <0.00%> (ø)
src/Mechanical/TranslationalModelica/utils.jl 0.00% <0.00%> (ø)
src/Mechanical/Rotational/utils.jl 75.00% <28.57%> (-8.73%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@baggepinnen baggepinnen marked this pull request as ready for review April 18, 2023 12:08
@baggepinnen baggepinnen merged commit 87b07ad into main Apr 19, 2023
@baggepinnen baggepinnen deleted the fb/msl_translational branch April 19, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant