Add Translational library similar to MSL #151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a version of the
Mechanical.Translational
that is more similar to the modelica versions than the two existingMechanical.Translational
andMechanical.TranslationalPosition
. There are several strong motivations for staying closer to the modelica equivalents:The multibody library uses the Translational library, and any deviation increases the multibody implementation effort many fold, as well as making it much more likely that we introduce bugs in the process. A graphical user interface becomes similarly more difficult to implement when a translation step is required between the open standard and our implementation, for us to be able to reuse existing assets. Lastly, the burden on existing modelica users who want to transition increases if we change variable names and definitions in subtle ways, with no clear benefit.
This implementation is quite a bit lighter weight than the current
TranslationalPosition
due to making use of partial models in the same way modelica does.