remove input annotations on RealInput #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not work as intended since the annotated variable resides inside a system without internal connections. Until MTK has more formally specified semantics for causal connections, we rely on the explicit passing of input variables to all functions that require it, such as linearize.
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 68.03% 70.17% +2.13%
==========================================
Files 25 25
Lines 1214 1177 -37
==========================================
Hits 826 826
+ Misses 388 351 -37
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
We should fix this in MTK instead. |
|
There is already a long lasting issue about this: SciML/ModelingToolkit.jl#1577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not work as intended since the annotated variable resides inside a system without internal connections. Until MTK has more formally specified semantics for causal connections, we rely on the explicit passing of input variables to all functions that require it, such as linearize.
@ValentinKaisermayer
This PR should resolve #49 (comment)