Skip to content

Update analysis points to use find/replace in MTK #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 29, 2022
Merged

Update analysis points to use find/replace in MTK #113

merged 10 commits into from
Sep 29, 2022

Conversation

baggepinnen
Copy link
Contributor

@baggepinnen baggepinnen commented Sep 28, 2022 •
edited
Loading

YingboMa and others added 3 commits September 27, 2022 11:03
@YingboMa @baggepinnen
WIP: use the new MTK find and replace functionality to implement AP
0c919b9 
Co-authored-by: Fredrik Bagge Carlson <baggepinnen@gmail.com>
@baggepinnen
update the rest of functions for linear analysis
79f40dd 
to use the find/replace funcitonality
@baggepinnen
rm comments
e244438
@codecov
Copy link

codecov bot commented Sep 28, 2022 •
edited
Loading

Codecov Report

Merging #113 (d70e7c7) into main (b7a9196) will increase coverage by 0.57%.
The diff coverage is 85.60%.

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   67.45%   68.03%   +0.57%     
==========================================
  Files          25       25              
  Lines        1177     1214      +37     
==========================================
+ Hits          794      826      +32     
- Misses        383      388       +5
Impacted Files Coverage Δ
src/Blocks/analysis_points.jl 74.39% <85.60%> (+3.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@baggepinnen baggepinnen reopened this Sep 28, 2022
YingboMa
YingboMa requested changes Sep 29, 2022
View reviewed changes
Copy link
Member

@YingboMa YingboMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is not included.

@YingboMa
Copy link
Member

Also, there's should be a version bound on MTK.

@baggepinnen
Copy link
Contributor Author

Good catches :) Both should be fixed now

@baggepinnen
bump compat MTK
a716bda 
for analysis point support
@baggepinnen baggepinnen force-pushed the analysis_point branch 3 times, most recently from 095e79b to 1e96325 Compare September 29, 2022 06:00
@YingboMa YingboMa merged commit 13bb219 into SciML:main Sep 29, 2022
@baggepinnen baggepinnen deleted the analysis_point branch September 29, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YingboMa YingboMa YingboMa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baggepinnen @YingboMa