refactor: remove old == and hash implementation for System
#3683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Jun 2, 2025
|
Should this be something we should drop in Catalyst too then? Is there now no notion of system equality, or is there another approach we should be taking? |
|
Yes. Its utility is questionable at best and the implementation is difficult and bug-prone. For the longest time, |
11 tasks
AayushSabharwal
force-pushed
the
as/rm-isequal-hash
branch
from
47c0404 to
2ebd53e
Compare
AayushSabharwal
force-pushed
the
as/rm-isequal-hash
branch
from
2ebd53e to
90c7c66
Compare
|
Yes, this was an intended change with the v10 that got missed somehow. But basically, the fallback |
ChrisRackauckas
approved these changes
Jun 3, 2025
|
Can merge, but we should make sure #3681 has all downstream green and passing before. We have enough downstream updated now that even extensions should all be fine, sans SI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.