feat: add adjoint for remake_buffer
#3042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/remake-buffer-adjoint
branch
from
0a22459 to
6d63145
Compare
AayushSabharwal
force-pushed
the
as/remake-buffer-adjoint
branch
from
6d63145 to
a246d55
Compare
ext/MTKChainRulesCoreExt.jl
Outdated
| tunable = selected_tangents(buf′.tunable, tunable_idxs) | ||
| discrete = selected_tangents(buf′.discrete, disc_idxs) | ||
| constant = selected_tangents(buf′.constant, const_idxs) | ||
| nonnumeric = selected_tangents(buf′.nonnumeric, nn_idxs) |
There was a problem hiding this comment.
I haven't checked, though the type-stability of the adjoint will largely depend on the type stability of idxs and vals
There was a problem hiding this comment.
selected_tangents is type-stable, the pullback is almost type stable with a couple changes if idxs and vals are type-stable. The only source of instability is the one selected_tangents method which uses similar(tangents, Union{T, NoTangent}) (which in fairness is a concretely typed union) and vals′
There was a problem hiding this comment.
However, if we restrict to the case of idxs only referring to values in the tunables, it's type-stable.
ChrisRackauckas
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.