Skip to content

feat: improve error messages for missing variables and subsystems #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AayushSabharwal
Copy link
Member

@AayushSabharwal AayushSabharwal commented Apr 5, 2024

Close #1747

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@baggepinnen
Copy link
Contributor

Nice tests 👍

@ChrisRackauckas ChrisRackauckas merged commit 0dc0f5d into SciML:master Apr 5, 2024
@AayushSabharwal AayushSabharwal deleted the as/better-missing-subsystem-error branch April 5, 2024 14:36
@YingboMa
Copy link
Member

YingboMa commented Apr 5, 2024

Why did we merge this PR? The test failures are clearly related to this PR.

@YingboMa
Copy link
Member

YingboMa commented Apr 5, 2024

@ChrisRackauckas
Copy link
Member

That must've been a mistake. I must've merged the wrong tab...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error messages for unlisted subsystems
4 participants