add option to set state priority as argument to structural_simplify…
#2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YingboMa
reviewed
Feb 3, 2023
baggepinnen
force-pushed
the
fb/priorities
branch
from
4875206 to
0d4f1a1
Compare
|
I added the system from https://discourse.julialang.org/t/why-is-modelingtoolkit-simplifying-this-way/96872 as test, but the fix in this PR does not actually help, the problem appears to have occurred already in the alias-elimination step, and state priorities are not considered until tearing. |
baggepinnen
force-pushed
the
fb/priorities
branch
from
0d4f1a1 to
3097cbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and friends
Closes #2001
And somewhat mitigates (but doesn't solve)
structural_simplify#2000