fix getvar access of state
#1824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of ```julia i = findfirst(x -> getname(x) == name, sts) ``` right above the added code was never used, causing some states not to be found. I'm no sure if the added code is correct, but something is at least missing here
baggepinnen
added a commit
to baggepinnen/ModelingToolkitStandardLibrary.jl
that referenced
this pull request
Sep 19, 2022
depends on SciML/ModelingToolkit.jl#1824
baggepinnen
added a commit
to baggepinnen/ModelingToolkitStandardLibrary.jl
that referenced
this pull request
Sep 19, 2022
depends on SciML/ModelingToolkit.jl#1824
baggepinnen
added a commit
to baggepinnen/ModelingToolkitStandardLibrary.jl
that referenced
this pull request
Sep 19, 2022
depends on SciML/ModelingToolkit.jl#1824
YingboMa
reviewed
Sep 20, 2022
| @@ -304,6 +304,9 @@ function getvar(sys::AbstractSystem, name::Symbol; namespace = false) | |||
|
|
|||
| sts = get_states(sys) | |||
There was a problem hiding this comment.
These are already handled above. We should just remove this block.
There was a problem hiding this comment.
I had an example that failed without this change but not with it. It's from the analysis point PR.
It might be related to how I added states to the system here?
There was a problem hiding this comment.
Ah, yeah, we should remember to update the var_to_name map, when vars are updated.
YingboMa
requested changes
Sep 20, 2022
|
Let's merge this for now, but we should work on a more efficient solution later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of
right above the added code was never used, causing some states not to be found. I'm no sure if the added code is correct, but something is at least missing here