Remove ipiv allocation from GenericLUFactorization #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| y = _ldiv!(cache.u, @get_cacheval(cache, $(Meta.quot(defaultalg_symbol(alg)))), | ||
| cache.b) | ||
| return SciMLBase.build_linear_solution(alg, y, nothing, cache; retcode = ReturnCode.Success) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| return SciMLBase.build_linear_solution(alg, y, nothing, cache; retcode = ReturnCode.Success) | |
| return SciMLBase.build_linear_solution( | |
| alg, y, nothing, cache; retcode = ReturnCode.Success) |
|
|
||
| cache.isfresh = false | ||
| end | ||
| y = ldiv!(cache.u, LinearSolve.@get_cacheval(cache, :GenericLUFactorization)[1], cache.b) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| y = ldiv!(cache.u, LinearSolve.@get_cacheval(cache, :GenericLUFactorization)[1], cache.b) | |
| y = ldiv!( | |
| cache.u, LinearSolve.@get_cacheval(cache, :GenericLUFactorization)[1], cache.b) |
ChrisRackauckas
force-pushed
the
generic_lufact_alloc
branch
from
b8b65a8 to
d51e5d0
Compare
Comment on lines
+4
to
+6
| function generic_lufact!(A::AbstractMatrix{T}, pivot::Union{RowMaximum,NoPivot,RowNonZero} = LinearAlgebra.lupivottype(T), | ||
| ipiv = Vector{LinearAlgebra.BlasInt}(undef, min(size(A)...)); | ||
| check::Bool = true, allowsingular::Bool = false) where {T} |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function generic_lufact!(A::AbstractMatrix{T}, pivot::Union{RowMaximum,NoPivot,RowNonZero} = LinearAlgebra.lupivottype(T), | |
| ipiv = Vector{LinearAlgebra.BlasInt}(undef, min(size(A)...)); | |
| check::Bool = true, allowsingular::Bool = false) where {T} | |
| function generic_lufact!(A::AbstractMatrix{T}, | |
| pivot::Union{RowMaximum, NoPivot, RowNonZero} = LinearAlgebra.lupivottype(T), | |
| ipiv = Vector{LinearAlgebra.BlasInt}(undef, min(size(A)...)); | |
| check::Bool = true, allowsingular::Bool = false) where {T} |
| check && LinearAlgebra.LAPACK.chkfinite(A) | ||
| # Extract values | ||
| m, n = size(A) | ||
| minmn = min(m,n) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| minmn = min(m,n) | |
| minmn = min(m, n) |
|
|
||
| # Initialize variables | ||
| info = 0 | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| info = 0 | ||
|
|
||
| @inbounds begin | ||
| for k = 1:minmn |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| for k = 1:minmn | |
| for k in 1:minmn |
Comment on lines
+21
to
+22
| for i = k+1:m | ||
| absi = abs(A[i,k]) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| for i = k+1:m | |
| absi = abs(A[i,k]) | |
| for i in (k + 1):m | |
| absi = abs(A[i, k]) |
Comment on lines
+102
to
+105
| for i = 1:n | ||
| tmp = A[k,i] | ||
| A[k,i] = A[kp,i] | ||
| A[kp,i] = tmp |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| for i = 1:n | |
| tmp = A[k,i] | |
| A[k,i] = A[kp,i] | |
| A[kp,i] = tmp | |
| for i in 1:n | |
| tmp = A[k, i] | |
| A[k, i] = A[kp, i] | |
| A[kp, i] = tmp |
Comment on lines
+109
to
+111
| Akkinv = inv(A[k,k]) | ||
| for i = k+1:m | ||
| A[i,k] *= Akkinv |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| Akkinv = inv(A[k,k]) | |
| for i = k+1:m | |
| A[i,k] *= Akkinv | |
| Akkinv = inv(A[k, k]) | |
| for i in (k + 1):m | |
| A[i, k] *= Akkinv |
Comment on lines
+117
to
+119
| for j = k+1:n | ||
| for i = k+1:m | ||
| A[i,j] -= A[i,k]*A[k,j] |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| for j = k+1:n | |
| for i = k+1:m | |
| A[i,j] -= A[i,k]*A[k,j] | |
| for j in (k + 1):n | |
| for i in (k + 1):m | |
| A[i, j] -= A[i, k] * A[k, j] |
| info = -info | ||
| end | ||
| check && LinearAlgebra._check_lu_success(info, allowsingular) | ||
| return LinearAlgebra.LU{T,typeof(A),typeof(ipiv)}(A, ipiv, convert(LinearAlgebra.BlasInt, info)) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| return LinearAlgebra.LU{T,typeof(A),typeof(ipiv)}(A, ipiv, convert(LinearAlgebra.BlasInt, info)) | |
| return LinearAlgebra.LU{T, typeof(A), typeof(ipiv)}( | |
| A, ipiv, convert(LinearAlgebra.BlasInt, info)) |
Comment on lines
+132
to
+134
| else | ||
| generic_lufact!(args...; kwargs...) = LinearAlgebra.generic_lufact!(args...; kwargs...) | ||
| end |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| else | |
| generic_lufact!(args...; kwargs...) = LinearAlgebra.generic_lufact!(args...; kwargs...) | |
| end | |
| else | |
| generic_lufact!(args...; kwargs...) = LinearAlgebra.generic_lufact!(args...; kwargs...) | |
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.