Skip to content

Fetching result sets from prepared statement #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 12, 2012
Merged

Fetching result sets from prepared statement #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
800f43a
fixed .gitignore to ignore Intellij IDEA project files
estliberitas Jun 1, 2012
45e35df
Added fetchAllSync() method
estliberitas Jun 1, 2012
31ded51
Disable temporarily warnings about not handled enums
estliberitas Jun 1, 2012
4154d3e
buffer for MYSQL_TYPE_TINY is unsigned int *
estliberitas Jun 1, 2012
908f785
buffer for MYSQL_TYPE_TINY is unsigned int *
estliberitas Jun 1, 2012
8a1c3da
TINYINT is handled as must be handled
Jun 1, 2012
8207fca
Fixed conversion to and from boolean values: bool to TINYINT
estliberitas Jun 10, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,5 @@ devdependencies-stamp
*.gcda
*.gcno
*.gcov
*.iml
.idea
177 changes: 177 additions & 0 deletions src/mysql_bindings_statement.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ void MysqlStatement::Init(Handle<Object> target) {
NODE_SET_PROTOTYPE_METHOD(constructor_template, "errnoSync", MysqlStatement::ErrnoSync);
NODE_SET_PROTOTYPE_METHOD(constructor_template, "errorSync", MysqlStatement::ErrorSync);
NODE_SET_PROTOTYPE_METHOD(constructor_template, "executeSync", MysqlStatement::ExecuteSync);
NODE_SET_PROTOTYPE_METHOD(constructor_template, "fetchAllSync", MysqlStatement::FetchAllSync);
NODE_SET_PROTOTYPE_METHOD(constructor_template, "fieldCountSync", MysqlStatement::FieldCountSync);
NODE_SET_PROTOTYPE_METHOD(constructor_template, "freeResultSync", MysqlStatement::FreeResultSync);
NODE_SET_PROTOTYPE_METHOD(constructor_template, "lastInsertIdSync", MysqlStatement::LastInsertIdSync);
Expand Down Expand Up @@ -305,6 +306,15 @@ Handle<Value> MysqlStatement::BindParamsSync(const Arguments& args) {
stmt->binds[i].buffer = int_data;
stmt->binds[i].is_null = 0;
stmt->binds[i].is_unsigned = false;
} else if (js_param->IsBoolean()) {
// I assume, booleans are usually stored as TINYINT(1)
int_data = new int;
*int_data = js_param->Int32Value();

stmt->binds[i].buffer_type = MYSQL_TYPE_TINY;
stmt->binds[i].buffer = int_data;
stmt->binds[i].is_null = 0;
stmt->binds[i].is_unsigned = false;
} else if (js_param->IsUint32()) {
uint_data = new unsigned int;
*uint_data = js_param->Uint32Value();
Expand Down Expand Up @@ -457,6 +467,173 @@ Handle<Value> MysqlStatement::ExecuteSync(const Arguments& args) {
return scope.Close(True());
}

/**
* Returns row data from statement result
*
* @return {Object}
*/
Handle<Value> MysqlStatement::FetchAllSync(const Arguments& args) {
HandleScope scope;

MysqlStatement *stmt = OBJUNWRAP<MysqlStatement>(args.This());

MYSQLSTMT_MUSTBE_INITIALIZED;
MYSQLSTMT_MUSTBE_PREPARED;

/* Get meta data for binding buffers */

unsigned int field_count = mysql_stmt_field_count(stmt->_stmt);

uint32_t i = 0, j = 0;
unsigned long length[field_count];
int row_count = 0;
my_bool is_null[field_count];
MYSQL_BIND bind[field_count];
MYSQL_RES *meta;
MYSQL_FIELD *fields;

/* Buffers */
int int_data[field_count];
signed char tiny_data[field_count];
double double_data[field_count];
char str_data[field_count][64];
MYSQL_TIME date_data[field_count];
memset(date_data, 0, sizeof(date_data));

memset(bind, 0, sizeof(bind));

meta = mysql_stmt_result_metadata(stmt->_stmt);

fields = meta->fields;
while (i < field_count) {
bind[i].buffer_type = fields[i].type;

switch(fields[i].type) {
case MYSQL_TYPE_NULL:
case MYSQL_TYPE_SHORT:
case MYSQL_TYPE_LONG:
case MYSQL_TYPE_LONGLONG:
case MYSQL_TYPE_INT24:
bind[i].buffer = &int_data[i];
break;
case MYSQL_TYPE_TINY:
bind[i].buffer = &tiny_data[i];
break;
case MYSQL_TYPE_FLOAT:
case MYSQL_TYPE_DOUBLE:
case MYSQL_TYPE_DECIMAL:
case MYSQL_TYPE_NEWDECIMAL:
bind[i].buffer = &double_data[i];
break;
case MYSQL_TYPE_STRING:
case MYSQL_TYPE_VAR_STRING:
case MYSQL_TYPE_VARCHAR:
bind[i].buffer = (char *) str_data[i];
bind[i].buffer_length = fields[i].length;
break;
case MYSQL_TYPE_YEAR:
case MYSQL_TYPE_DATE:
case MYSQL_TYPE_NEWDATE:
case MYSQL_TYPE_TIME:
case MYSQL_TYPE_DATETIME:
case MYSQL_TYPE_TIMESTAMP:
bind[i].buffer = (char *) &date_data[i];
}

bind[i].is_null = &is_null[i];
bind[i].length = &length[i];
i++;
}

/* If error on binding return null */
if (mysql_stmt_bind_result(stmt->_stmt, bind)) {
return scope.Close(Null());
}

/* If error on buffering results return null */
if (mysql_stmt_store_result(stmt->_stmt)) {
return scope.Close(Null());
}

Local<Array> js_result_rows = Array::New();
Local<Object> js_result_row;
Local<Value> js_result;

row_count = mysql_stmt_num_rows(stmt->_stmt);

/* If no rows, return empty array */
if (!row_count) {
return scope.Close(js_result_rows);
}

i = 0;
while (mysql_stmt_fetch(stmt->_stmt) != MYSQL_NO_DATA) {
js_result_row = Object::New();

j = 0;
while (j < field_count) {
switch(fields[j].type) {
case MYSQL_TYPE_NULL:
case MYSQL_TYPE_SHORT:
case MYSQL_TYPE_LONG:
case MYSQL_TYPE_LONGLONG:
case MYSQL_TYPE_INT24:
js_result = Integer::New(int_data[j]);
break;
case MYSQL_TYPE_TINY:
if (length[j] == 1) {
js_result = BooleanObject::New(tiny_data[j] == true);
} else {
js_result = Integer::NewFromUnsigned(tiny_data[j]);
}
break;
case MYSQL_TYPE_FLOAT:
case MYSQL_TYPE_DOUBLE:
js_result = Number::New(double_data[j]);
break;
case MYSQL_TYPE_DECIMAL:
case MYSQL_TYPE_NEWDECIMAL:
js_result = Number::New(double_data[j])->ToString();
break;
case MYSQL_TYPE_STRING:
case MYSQL_TYPE_VAR_STRING:
case MYSQL_TYPE_VARCHAR:
js_result = V8STR2(str_data[j], length[j]);
break;
case MYSQL_TYPE_YEAR:
case MYSQL_TYPE_DATE:
case MYSQL_TYPE_NEWDATE:
case MYSQL_TYPE_TIME:
case MYSQL_TYPE_DATETIME:
case MYSQL_TYPE_TIMESTAMP:
MYSQL_TIME ts = date_data[j];
time_t rawtime;
struct tm * datetime;
time(&rawtime);
datetime = localtime(&rawtime);
datetime->tm_year = ts.year - 1900;
datetime->tm_mon = ts.month - 1;
datetime->tm_mday = ts.day;
datetime->tm_hour = ts.hour;
datetime->tm_min = ts.minute;
datetime->tm_sec = ts.second;
time_t timestamp = mktime(datetime);

js_result = Date::New(1000 * (double) timestamp);
break;
}

js_result_row->Set(V8STR(fields[j].name), js_result);
j++;
}

js_result_rows->Set(Integer::NewFromUnsigned(i), js_result_row);
i++;
}

return scope.Close(js_result_rows);
}

/**
* Returns the number of field in the given statement
*
Expand Down
2 changes: 2 additions & 0 deletions src/mysql_bindings_statement.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ class MysqlStatement : public node::ObjectWrap {

static Handle<Value> ExecuteSync(const Arguments& args);

static Handle<Value> FetchAllSync(const Arguments& args);

static Handle<Value> FieldCountSync(const Arguments& args);

static Handle<Value> FreeResultSync(const Arguments& args);
Expand Down
2 changes: 1 addition & 1 deletion wscript
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def configure(conf):
conf.check_tool("node_addon")

# Enables all the warnings that are easy to avoid
conf.env.append_unique('CXXFLAGS', ["-Wall"])
conf.env.append_unique('CXXFLAGS', ["-Wall", "-Wno-switch"])
if Options.options.warn:
# Extra warnings
conf.env.append_unique('CXXFLAGS', ["-Wextra"])
Expand Down