Skip to content

[LAB1] 110550174 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2024
Merged

[LAB1] 110550174 #27

merged 2 commits into from
Mar 7, 2024

Conversation

DENGRENHAO
Copy link

@DENGRENHAO DENGRENHAO commented Feb 29, 2024

Description

#2


  • A clear title (name your pr "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing tests/CI

@DENGRENHAO DENGRENHAO closed this Feb 29, 2024
@DENGRENHAO DENGRENHAO reopened this Feb 29, 2024
@TaiYou-TW TaiYou-TW closed this Feb 29, 2024
@TaiYou-TW TaiYou-TW reopened this Feb 29, 2024
@TaiYou-TW TaiYou-TW added the lab1 label Feb 29, 2024
Comment on lines +5 to +14
// const myClass = new MyClass();
// const names = ['John', 'Jane', 'Doe', 'Smith'];
// names.forEach(name => {
// const student = new Student();
// student.setName(name);
// const newStudentId = myClass.addStudent(student);
// const newStudentName = myClass.getStudentById(newStudentId).getName();
// console.log('[+] Added student with id: %d, name: %s', newStudentId, newStudentName);
// });

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not leave a bunch of comment code in your commit.
I will merge the PR first, but it's better to remove them next time.

@TaiYou-TW TaiYou-TW merged commit 95f108e into SQLab:110550174 Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants