Skip to content

Update the Travis-CI to use Catalina and enable macOS test case #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2020

Conversation

dreampiggy
Copy link
Collaborator

This enable the macOS test cases, previouslly travis has only support macOS 10.14...:)

@dreampiggy
Copy link
Collaborator Author

dreampiggy commented Apr 14, 2020

Travis does not still support macOS Catalina. Close currently :(
See: https://travis-ci.community/t/xcode-11-4-image-uses-macos-version-that-is-unsupported-by-that-version-of-xcode/8111

@dreampiggy dreampiggy closed this Apr 14, 2020
@dreampiggy dreampiggy reopened this May 12, 2020
@dreampiggy
Copy link
Collaborator Author

dreampiggy commented May 12, 2020

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #98 into master will increase coverage by 2.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   71.58%   74.13%   +2.55%     
==========================================
  Files           9        9              
  Lines         834      901      +67     
==========================================
+ Hits          597      668      +71     
+ Misses        237      233       -4     
Flag Coverage Δ
#ios 72.01% <ø> (+0.43%) ⬆️
#macos 75.42% <ø> (?)
Impacted Files Coverage Δ
...eSwiftUI/Classes/Indicator/ProgressIndicator.swift 69.09% <0.00%> (-5.91%) ⬇️
...eSwiftUI/Classes/Indicator/ActivityIndicator.swift 93.10% <0.00%> (-0.23%) ⬇️
SDWebImageSwiftUI/Classes/ImageManager.swift 69.84% <0.00%> (+0.48%) ⬆️
SDWebImageSwiftUI/Classes/AnimatedImage.swift 74.44% <0.00%> (+0.84%) ⬆️
SDWebImageSwiftUI/Classes/ImageViewWrapper.swift 87.09% <0.00%> (+4.40%) ⬆️
SDWebImageSwiftUI/Classes/WebImage.swift 84.15% <0.00%> (+7.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed96d9...fdd36a0. Read the comment docs.

@dreampiggy dreampiggy merged commit 28e6849 into master May 12, 2020
@dreampiggy dreampiggy deleted the travis_catalina branch May 12, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant