Skip to content

Don't embed SDWebImage.framework in SDWebImageSwiftUI.framework #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Conversation

jonkan
Copy link
Contributor

@jonkan jonkan commented Apr 9, 2020

Solves #96

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #97 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   75.53%   75.53%           
=======================================
  Files           9        9           
  Lines         748      748           
=======================================
  Hits          565      565           
  Misses        183      183           
Flag Coverage Δ
#ios 75.53% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdfac45...c5a1512. Read the comment docs.

@dreampiggy
Copy link
Collaborator

Good catch.

But you only change the SDWebImageSwiftUI iOS framework target. There are 4 targets totally. The diff should looks like this:

image

@dreampiggy
Copy link
Collaborator

@jonkan Do I need to create another PR ? Or you fix it and commit again ?

I'll wait for reply until tomorrow, or I'll fix it by another PR.

@jonkan
Copy link
Contributor Author

jonkan commented Apr 10, 2020

Ah sorry, forgot them. I'll fix.

@dreampiggy dreampiggy merged commit 5af223d into SDWebImage:master Apr 10, 2020
@dreampiggy
Copy link
Collaborator

dreampiggy commented Apr 10, 2020

Fixed and released with v1.3.1. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants