Feature AnimatedImage placeholder view builder #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…better than UIImage for common customizable placeholders
dreampiggy
force-pushed
the
feature_animated_placeholder_view_builder
branch
from
c82ffce to
eb6c7f1
Compare
dreampiggy
force-pushed
the
feature_animated_placeholder_view_builder
branch
from
eb6c7f1 to
1e1ddcc
Compare
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 73.49% 75.53% +2.03%
==========================================
Files 9 9
Lines 732 748 +16
==========================================
+ Hits 538 565 +27
+ Misses 194 183 -11
Continue to review full report at Codecov.
|
dreampiggy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports the
@ViewBuilderAPI to create placeholder onAnimatedImage.The channlege is that
AnimatedImageuseUIViewRepresentable, which thebodyfunc is override by SwiftUI internel logic. So we can not use the same design asWebImage(which return different Image based on loading status)So, instead, we use the HostingView, to inject the View Hierarchy. The placeholder is above the original SDAnimatedImageView, and controls its
isHiddenproperty during loading.Note the placeholder and indicator can be used at the same time, we need to considerate this case and adjust the View Hierarchy level