Fix the issue when using WebImage with some transition like scaleEffect, each time the new state update will cause unused image fetching #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See our demo:
Before this fix, when network load failed, each time you zoom your finder, the new SDWebImage loadImage function call will trigger, this cause huge performance cost, worstly, the UI part will show a placeholder with flashback.
To workaround with this, we roll back to load the image in
WebImage's first Appear
. However, we have to solve the issue #20 #19So, this time, we use a trick (smart ?) solution: We query the memory cache firstlly during WebImage init method. This is fast because it just a NSCache objectForKey call.
If memory cache hit, the image does not show placeholder or empty, so fix the
editMode
issue.