Skip to content

Using the intrinsicContentSize on wrapper container, try to fix the aspect ratio sizing issue #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2019
Merged

Using the intrinsicContentSize on wrapper container, try to fix the aspect ratio sizing issue #36

merged 1 commit into from
Oct 29, 2019

Conversation

dreampiggy
Copy link
Collaborator

@dreampiggy dreampiggy commented Oct 29, 2019 •
edited
Loading

Hope this is the final change ;)

  • Before fix:

image

  • After fix:

image

The after fix is what Image and WebImage behavior. So we should fix that to match them.

@dreampiggy
Using the intrinsicContentSize on wrapper container, try to fix the a…
149f265 
…spect ratio sizing issue, hope this is the final change
@dreampiggy dreampiggy added apple bug Apple's bug that need workaround fix labels Oct 29, 2019
@dreampiggy dreampiggy merged commit 2d07004 into master Oct 29, 2019
@dreampiggy dreampiggy deleted the bugfix_AnimatedImage_aspect_fix_final branch October 29, 2019 18:14
@mjswen0923 mjswen0923 mentioned this pull request Sep 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
apple bug Apple's bug that need workaround fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dreampiggy