Fix that AnimatedImage on watchOS, does not stop animating when disappear and cause performance issue #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreampiggy
commented
Oct 26, 2019
…age decoding and animation does not stop issue. Increase performance
…ot take effect issue
dreampiggy
force-pushed
the
bugfix_watchOS_animatedimage_stop_when_disappear
branch
from
17af6d5 to
5582b33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't find any documentation about How a UIViewRepresentable or WKInterfaceObjectRepresentable can response to
onAppearoronDisappearBecauseUIViewRepresentablecan not override itself with view modifier, and no public API here.Previouslly there is a bug that watchOS does not behave correctly. (If we nagivate to detail page, list page animated images still animating and consume CPU)
One simple solution, create a extra wrapper for watchOS (which
View.bodyis just aAnimatedImageand configedonAppear,onDisappearto control animating). But I really don't want to do so, which looks suck. 🤮However, I found that when
onAppearoronDisappear, the view'supdateWKInterfaceObjectmethod will be called. So we can use this to detect current visibility. (Using internal UIView.window to detect)