Skip to content

update Published properties of ImageManager in the main thread #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

update Published properties of ImageManager in the main thread #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions SDWebImageSwiftUI/Classes/ImageManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ public final class ImageManager : ObservableObject {
if currentOperation != nil {
return
}
self.isLoading = true
DispatchQueue.main.async {
self.isLoading = true
}
currentOperation = manager.loadImage(with: url, options: options, context: context, progress: { [weak self] (receivedSize, expectedSize, _) in
guard let self = self else {
return
Expand All @@ -89,14 +91,18 @@ public final class ImageManager : ObservableObject {
// So previous View struct call `onDisappear` and cancel the currentOperation
return
}
self.image = image
self.error = error
self.isIncremental = !finished
DispatchQueue.main.async {
self.image = image
self.error = error
self.isIncremental = !finished
}
if finished {
self.imageData = data
self.cacheType = cacheType
self.isLoading = false
self.progress = 1
DispatchQueue.main.async {
self.imageData = data
self.cacheType = cacheType
self.isLoading = false
self.progress = 1
}
if let image = image {
self.successBlock?(image, data, cacheType)
} else {
Expand Down