Refactor WebImage/AnimatedImage using SwiftUIBackports and StateObject #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Use SwiftUIBackport to use StateObject/OnChange/Overlay 2. Change the Indicator API to match the transform for ImageManager 3. Remove the unused PlatformApear hack
dreampiggy
added
API
dreampiggy
force-pushed
the
refactor_xcode14_state_update
branch
from
652419a to
53a4349
Compare
Use context.coordinator to store loading status because it's exclusive unlike normal SwiftUI.View
Added something about the behavior
dreampiggy
force-pushed
the
refactor_xcode14_state_update
branch
from
53a4349 to
e86386c
Compare
dreampiggy
force-pushed
the
refactor_xcode14_state_update
branch
4 times, most recently
from
e77305f to
c807dce
Compare
dreampiggy
force-pushed
the
refactor_xcode14_state_update
branch
from
c807dce to
4b7cbfc
Compare
|
The test cases failed because the ViewInspector no longer can find the May fix later, currently I just merge and release v2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR close #225 #222
Note
This is the Last Version which support iOS 13. The back port is really pain
Changes
WebImage
AnimatedImage
API Break
IndicatorReportabledesign is wrong. And removed withIndicatorStatusObservableObject class. You can migrate using a self-created@ObservedObject var status = IndicatorStatus(), then useonReceive(myLoadingStatus)to trigger update on thatIndicatorStatus(I don't think anyone beside me use this API, actually this does not effect the user-level
.indicator(.progress)API...)Warnings
@garrettrayj