Skip to content

Update availability for all extensions for consistency #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2020

Conversation

master-nevi
Copy link
Contributor

@master-nevi master-nevi commented Jul 21, 2020

Several extensions were missing the @available attributes.

@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   72.52%   72.52%           
=======================================
  Files           9        9           
  Lines         921      921           
=======================================
  Hits          668      668           
  Misses        253      253           
Flag Coverage Δ
#ios 70.35% <ø> (ø)
#macos 73.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
SDWebImageSwiftUI/Classes/Image.swift 40.90% <ø> (ø)
SDWebImageSwiftUI/Classes/ImageManager.swift 69.84% <ø> (ø)
SDWebImageSwiftUI/Classes/ImageViewWrapper.swift 87.09% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c7f169...62f332f. Read the comment docs.

@dreampiggy
Copy link
Collaborator

These API is not public API. So it does not effect the lower firmware compatibility.

Anyway, it's OK.

@dreampiggy dreampiggy merged commit 0c23726 into SDWebImage:master Jul 22, 2020
@dreampiggy dreampiggy added the enhancement New feature or request label Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants