Skip to content

Add the same overload method for onSuccess API, which introduce the image data arg. Keep the source code compatibility #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2020

Conversation

dreampiggy
Copy link
Collaborator

This solve the #104.

By using the overload method, this can keep source code compatibility, so this is marked as 1.x not 2.x.

@dreampiggy dreampiggy added the API API changes label May 6, 2020
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #109 into master will decrease coverage by 1.27%.
The diff coverage is 51.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   72.86%   71.58%   -1.28%     
==========================================
  Files           9        9              
  Lines         807      834      +27     
==========================================
+ Hits          588      597       +9     
- Misses        219      237      +18     
Flag Coverage Δ
#ios 71.58% <51.42%> (-1.28%) ⬇️
Impacted Files Coverage Δ
SDWebImageSwiftUI/Classes/WebImage.swift 77.00% <10.00%> (-3.63%) ⬇️
SDWebImageSwiftUI/Classes/ImageManager.swift 69.35% <55.55%> (-5.20%) ⬇️
SDWebImageSwiftUI/Classes/AnimatedImage.swift 73.60% <75.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a347dc...f36440f. Read the comment docs.

@dreampiggy dreampiggy merged commit 3f2f135 into master May 7, 2020
@dreampiggy dreampiggy deleted the feature_support_data_arg_2 branch May 7, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API changes feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant