WebImage can not use Custom SDWebImageManager

[takep2]

I want to use WebImage with Firebase Storage API.
For that, WebImage needs to be able to use Custom SDWebImageManager with modified loader.

In the sd_internalSetImageWithURL method of SDWebImage, the following code is used to use Custom SDWebImageManager set in the context.

        SDWebImageManager *manager = context[SDWebImageContextCustomManager];
        if (!manager) {
            manager = [SDWebImageManager sharedManager];
        }

However, ImageManager of SDWebImageSwiftUI always uses the default SDWebImageManager by the following code.

var manager = SDWebImageManager.shared

I hope to add the following code to the load method in the ImageManager so that the manager set in the context can be used.

        if let customManager = context?[.customManager] as? SDWebImageManager {
            manager = customManager
        }

[dreampiggy]

Sounds a design changes. Maybe this means, we should use the context option's manager instead always the shared one.

It's not hard to implements, PR is welcomed, or please wait me for days of Spring Festival, thanks ~

[dreampiggy]

@takep2 For Firbase URL, have you ever tried the SDImageLoadersManager ? See wiki: https://github.com/SDWebImage/SDWebImage/wiki/Advanced-Usage#loaders-manager

Which implements a multiple loader system, like:

SDImageLoadersManager.shared.loaders = [SDWebImageDownloader.shared, FirebaseUI. StorageImageLoader.shared]
// Then you can query both HTTP/HTTPS/FTP/File/Firebase URL at the same time, no need to check

[takep2]

Thank you for the great advice!

I did not know that the default loader of SDWebImageManager could be replaced later.

Based on this advice, I was able to list images using WebImage loaded by Firebase Storage API as the following code.

import SwiftUI
import Firebase
import FirebaseUI
import SDWebImageSwiftUI

struct ContentView: View {
    @State var postArray: [PostData] = []
    
    var body: some View {
        List(self.postArray) { (postData) in
            VStack {
                WebImage(url: self.imageURL(postData.imageName))
                    .resizable()
                    .indicator(.activity)
                    .scaledToFit()
                    .frame(minHeight:200)
            }
        }.onAppear() {
            SDWebImageManager.defaultImageLoader = StorageImageLoader.shared
            self.loadData()
        }
    }
    
    func loadData() {
        // loading image names to postArray 
    }
    
    func imageURL(_ imageName: String)->URL {
        let ref = Storage.storage().reference().child("images").child(imageName)
        let url = NSURL.sd_URL(with: ref)! as URL
        return url
    }

The problem was solved very simply.

Thanks for providing a great library!

[dreampiggy]

This may solve your problem. However, changning the default loader to a single one (like those FirebaseUI) will cause you can not download any HTTP/HTTPS URL.

So, the better idea, it's to use LoadersManager, which implements a multiple loaders system, which means, you can load any of resources at the same time, without checking what's input URL is:

• HTTP/HTTPS
• FTP
• File(file://)
• Firebase Storage
• Photos Assets (Using https://github.com/SDWebImage/SDWebImagePhotosPlugin)

And, the correct code to setup the loaders, it's not a ContentView.onAppear. It should be placed in advance before the UI rendering, like the AppDelegate. Read our readme's Customization and configuration setup, you will know more about this.

Or, I can release a new release that supports the context options's manager to works. Please have a wait.

[dreampiggy]

@takep2 Version v0.10.1 supports to keep the .customManager context option.

But, it's recommend to just try out the v1.0.0-beta version, which provide a stable API (in long-term) and better support for AnimatedImage on WebImage. See more about v1.0.0 beta release

[Dwite]

Hello @dreampiggy, so do you have an example of how it should work? I'm trying to make it work with Firebase "gs://" URLs as they mentioned in https://github.com/firebase/FirebaseUI-iOS/blob/master/Storage/README.md

// Use gs:// URL directly with StorageImageLoader
let storageUrl = URL(string: "gs://...")!

With simple WebImage as

WebImage(url: book.thumbnail)
            .frame(width: 100, height: 100)

and configured

SDImageLoadersManager.shared.loaders = [SDWebImageDownloader.shared, FirebaseUI.StorageImageLoader.shared]

But receive such error

Task <22AEFC72-C893-4E2B-9279-572AE567A64D>.<1> finished with error [-1002] Error Domain=NSURLErrorDomain Code=-1002 "unsupported URL" UserInfo={NSLocalizedDescription=unsupported URL, NSErrorFailingURLStringKey=gs://stickerland-smartfox.appspot.com/QIWInaKazhdiyDen/CAACAgIAAxkBAAIWk19SL-_471VlEnz22e-4h-D6CXr7AAK3LAEAAWOLRgyY67_5bQXHLBsE.webp, NSErrorFailingURLKey=gs://stickerland-smartfox.appspot.com/QIWInaKazhdiyDen/CAACAgIAAxkBAAIWk19SL-_471VlEnz22e-4h-D6CXr7AAK3LAEAAWOLRgyY67_5bQXHLBsE.webp, _NSURLErrorRelatedURLSessionTaskErrorKey=(
    "LocalDataTask <22AEFC72-C893-4E2B-9279-572AE567A64D>.<1>"

If I make the FirebaseUI.StorageImageLoader.shared as default loader the is no error, but also no image is shown

[dreampiggy]

@Dwite Your loaders array order is wrong...It's a priority queue. So it should be

SDImageLoadersManager.shared.loaders = [FirebaseUI.StorageImageLoader.shared, SDWebImageDownloader.shared]

SDWebImageDownloader (The default loader), actually will handler any URL, whatever it use HTTP/FTP, or any custom Scheme (gs:// is one)

[Dwite]

@dreampiggy even if I change the order, the problem still exists. If I remove the SDWebImageDownloader.shared completely

SDImageLoadersManager.shared.loaders = [FirebaseUI.StorageImageLoader.shared]
SDWebImageManager.defaultImageLoader = SDImageLoadersManager.shared

There are no errors in logs, but images won't appear and all WebImage.onFailure are called with empty error domain: nil - code: 0

[dreampiggy]

Can you please provide a demo (and your Firebase Storage URL) for me to test ? Sounds little strange, because the loading system for UIKit or SwiftUI are shared. So it should handle the gs as well. Or the FirebaseUI-Storage Unit Test will fail...

I remember last time I tested with that Firebase Plugin was April. Anything changed ?

[Dwite]

@dreampiggy I have added you as a contributor to my project, it's almost empty, just the code with the web image + Firebase storage

Here is an example URL

gs://stickerland-smartfox.appspot.com/ChristisRisen_stickers/CAACAgIAAxkBAAIWll9SL_vXzeNSk1NjK8B-XeWWvMECAALcyQEAAWOLRgy0EthwY9D3JRsE.webp

[dreampiggy]

FirebaseStorage UI version wrong :)

The fixed code (which supports raw NSURL, not NSURL created with special API (sd_sd_URLWithStorageReference), already on master: https://github.com/firebase/FirebaseUI-iOS/blob/master/Storage/FirebaseStorageUI/FUIStorageImageLoader.m#L53-L63

However, your example code: