Skip to content

Add branching strategy and contribution guide #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2022
Merged

Add branching strategy and contribution guide #53

merged 2 commits into from
Sep 4, 2022

Conversation

John15321
Copy link
Contributor

@John15321 John15321 commented Sep 3, 2022 •
edited
Loading

Add branching strategy explanation and contributing guide for new developers on how to work on the project.

@John15321 John15321 added the documentation Improvements or additions to documentation label Sep 3, 2022
@John15321 John15321 self-assigned this Sep 3, 2022
@John15321 John15321 linked an issue Sep 3, 2022 that may be closed by this pull request
Add the branching strategy to the README #28
Closed
@John15321 John15321 marked this pull request as ready for review September 3, 2022 22:18
Allstreamer
Allstreamer reviewed Sep 3, 2022
View reviewed changes
Copy link
Collaborator

@Allstreamer Allstreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contribution Guide should probably mention formatting for pull requests i.e.

  • that the issue Number should be in the title
  • summary of changes in the body of the pull
  • Labels
  • Milestone
  • etc

@Allstreamer Allstreamer self-requested a review September 3, 2022 22:39
@John15321
Copy link
Contributor Author

Contribution Guide should probably mention formatting for pull requests i.e.

  • that the issue Number should be in the title
  • summary of changes in the body of the pull
  • Labels
  • Milestone
  • etc

oh yeah I forgot about that

@John15321
Copy link
Contributor Author

Contribution Guide should probably mention formatting for pull requests i.e.

  • that the issue Number should be in the title
  • summary of changes in the body of the pull
  • Labels
  • Milestone
  • etc

Okay I added some, I wont be making it too detailed like cmon

DevChaudhary78
DevChaudhary78 approved these changes Sep 4, 2022
View reviewed changes
Copy link
Collaborator

@DevChaudhary78 DevChaudhary78 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTRIBUTING.md is very descriptive, short as well as long versions are appreciated, approving this. 👍

@DevChaudhary78 DevChaudhary78 merged commit d62890c into develop Sep 4, 2022
@DevChaudhary78 DevChaudhary78 deleted the 28-add-the-branching-strategy-to-the-readme branch September 4, 2022 05:39
@John15321
Copy link
Contributor Author

CONTRIBUTING.md is very descriptive, short as well as long versions are appreciated, approving this. 👍

You shouldn't merge it yourself, the author of the PR does the merge, not to mention that you should have waited for everyone's approve

@DevChaudhary78
Copy link
Collaborator

Ohh okay my bad, I will make a note of this next time sorry 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DevChaudhary78 DevChaudhary78 DevChaudhary78 approved these changes

@zephaniahong zephaniahong Awaiting requested review from zephaniahong

@Allstreamer Allstreamer Awaiting requested review from Allstreamer

Assignees

@John15321 John15321

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
📃 Documentation
Development

Successfully merging this pull request may close these issues.

Add the branching strategy to the README
3 participants
@John15321 @DevChaudhary78 @Allstreamer