cached execution statistics #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swilly22
reviewed
Jun 9, 2020
test.py
Outdated
Comment on lines
190
to
198
| def test_cached_execution(self): | ||
| redis_graph = Graph('cached', self.r) | ||
| redis_graph.query("CREATE ()") | ||
| uncached_result = redis_graph.query("MATCH (n) RETURN n") | ||
| cached_result = redis_graph.query("MATCH (n) RETURN n") | ||
| self.assertEqual(uncached_result.result_set, cached_result.result_set) | ||
| self.assertFalse(uncached_result.cached_execution) | ||
| self.assertTrue(cached_result.cached_execution) | ||
|
|
There was a problem hiding this comment.
I can't merge this until execution-plan cache is merged.
swilly22
suggested changes
Jun 9, 2020
redisgraph/query_result.py
Outdated
Comment on lines
228
to
236
| return float(stat.split(': ')[1].split(' ')[0]) | ||
| if(prop == "Cached execution"): | ||
| value = stat.split(': ')[1].split(' ')[0] | ||
| if value == "true": | ||
| return True | ||
| elif value == "false": | ||
| return False | ||
| else: | ||
| return float(stat.split(': ')[1].split(' ')[0]) |
There was a problem hiding this comment.
Why can't "Cached execution" be 0 or 1.
this would save this clunky parsing.
swilly22
suggested changes
Jun 18, 2020
redisgraph/query_result.py
Outdated
| @@ -274,7 +268,7 @@ def indices_deleted(self): | |||
|
|
|||
| @property | |||
| def cached_execution(self): | |||
| return self._get_stat(self.CACHED_EXECUTION) | |||
| return True if self._get_stat(self.CACHED_EXECUTION) == 1 else False | |||
There was a problem hiding this comment.
return self._get_stat(self.CACHED_EXECUTION) == 1
swilly22
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.