add support for path type #53
Conversation
|
This pull request introduces 2 alerts when merging 529502e into 7a70219 - view on LGTM.com new alerts:
|
redisgraph/query_result.py
Outdated
| def parse_path(self, cell): | ||
| nodes = self.parse_scalar(cell[0]) | ||
| relationships = self.parse_scalar(cell[1]) | ||
| return Path(nodes, relationships) |
There was a problem hiding this comment.
Assert both nodes and relationships types, consider performing the assertion in Path's constructor
|
This pull request introduces 2 alerts when merging 24abf0a into 7a70219 - view on LGTM.com new alerts:
|
test.py
Outdated
| redis_graph.add_edge(edge01) | ||
| redis_graph.add_edge(edge12) | ||
|
|
||
| redis_graph.commit() |
redisgraph/path.py
Outdated
| @classmethod | ||
| def new_path(cls, nodes, edges): | ||
| return cls(nodes, edges) | ||
|
|
There was a problem hiding this comment.
Remove this function, use constructor.
|
This pull request introduces 2 alerts when merging 229b3d6 into 7a70219 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 80.62% 80.62%
=======================================
Files 7 7
Lines 387 387
=======================================
Hits 312 312
Misses 75 75Continue to review full report at Codecov.
|
| def add_node(self, node): | ||
| assert(isinstance(node, self.append_type)) | ||
| self.nodes.append(node) | ||
| self.append_type = Edge |
There was a problem hiding this comment.
self.append_type = type(Edge) seems more aligned with the naming.
but then assert(isinstance(node, self.append_type)) should be updated to
assert(type(node) == self.append_type)
redisgraph/path.py
Outdated
| return self | ||
|
|
||
| def add_edge(self, edge): | ||
| assert(isinstance(edge, self.append_type)) |
|
This pull request introduces 2 alerts when merging 7db8259 into 7a70219 - view on LGTM.com new alerts:
|
README.md
Outdated
| # See path.py for more path API. | ||
| print(path.edge_count(), path.nodes_count()) |
There was a problem hiding this comment.
The example should print the path, don't refer users to source code within the readme.
README.md
Outdated
| # Iterate through resultset | ||
| for record in result.result_set: | ||
| path = record[0] | ||
| # See path.py for more path API. |
There was a problem hiding this comment.
Please remove this comment.
|
This pull request introduces 2 alerts when merging 02710d6 into 7a70219 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging a01df09 into 7a70219 - view on LGTM.com new alerts:
|
No description provided.