Skip to content

[markov_chain_I] Update animation for different initial distributions #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

longye-tian
Copy link
Collaborator

Dear John @jstac,

This pull request updates the Markov chain animation for different initial distributions.

In addition, this pull request also updates the descriptions of the code.

The previous pull request, #492, can be closed as this one has no merge conflict.

Best ❤️
Longye

Dear John,

This pull request updates the Markov chain animation for different initial distributions.

In addition, this pull request also updates the descriptions of the code.

The previous pull request #492  can be closed as this one has no merge conflict.

Best,
Longye
@longye-tian longye-tian requested review from mmcky and jstac July 17, 2024 02:45
Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 3c0b75f
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/6698efe68ea140000832ad3e
😎 Deploy Preview https://deploy-preview-515--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jul 17, 2024

@github-actions github-actions bot temporarily deployed to pull request July 17, 2024 03:06 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 17, 2024 03:08 Inactive
@jstac
Copy link
Contributor

jstac commented Jul 18, 2024

Thanks @longye-tian , great animations!

@mmcky , perhaps we should hide the code? Also, should we / can we set the default to "loop" rather than "once" for both of these animations? Please merge when ready.

@mmcky
Copy link
Contributor

mmcky commented Jul 18, 2024

thanks @jstac I agree with hiding the code.

@longye-tian can you please add :tags: hide-input to the code-cell directive.

@mmcky
Copy link
Contributor

mmcky commented Jul 18, 2024

Also, should we / can we set the default to "loop" rather than "once" for both of these animations?

@jstac I think once is best -- sometimes I find when I go to a website and it loops eternally it is distracting. I think the play button would be a clear way to run it again.

@github-actions github-actions bot temporarily deployed to pull request July 18, 2024 10:41 Inactive
@longye-tian
Copy link
Collaborator Author

thanks @jstac I agree with hiding the code.

@longye-tian can you please add :tags: hide-input to the code-cell directive.

Hi Matt,

I have added the hide input tag to both the animation code.

Best,
Longye

@github-actions github-actions bot temporarily deployed to pull request July 18, 2024 10:43 Inactive
@mmcky
Copy link
Contributor

mmcky commented Jul 18, 2024

thanks @longye-tian and @jstac.

@mmcky mmcky merged commit 8b9175d into main Jul 18, 2024
7 checks passed
@mmcky mmcky deleted the markov_chain_I_animation_edit branch July 18, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants