Skip to content

Fix a small typo in line 777 #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix a small typo in line 777 #444

merged 1 commit into from
May 21, 2024

Conversation

dangarciahe
Copy link
Contributor

Fixing typo in line 777. It incorrectly called the supply vector as q^d, instead of q^s

Fixing typo in line 777. It incorrectly  called the supply vector as q^d, instead of q^s
Copy link

netlify bot commented May 17, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit c05db95
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/6646a6863a0a7f0008ef3c33
😎 Deploy Preview https://deploy-preview-444--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmcky
Copy link
Contributor

mmcky commented May 17, 2024

thanks @dangarciahe for your PR. It is really helpful.

@shlff would you mind to review and tag as ready when you have the chance.

@shlff
Copy link
Member

shlff commented May 17, 2024

Thanks for correcting the typo in the lecture linear_equations @dangarciahe .

Thanks @mmcky . I've reviewed this pr, which looks good to me.

So I reckon it is ready to be merged.

@shlff shlff added the ready label May 17, 2024
@dangarciahe
Copy link
Contributor Author

Hello, @mmcky and @shlff. I have a question regarding this kind of PR that fixes such small things. I see that reviewing PRs takes time, and if they fix small stuff it could the case that the project as a whole would be better of without them.
Do you think that is the case?

@mmcky
Copy link
Contributor

mmcky commented May 21, 2024

@dangarciahe the PR is greatly appreciated. Please keep them coming no matter the size.

I have a policy to always get a double check when it involves math or code -- we really appreciate the fix.

@mmcky mmcky merged commit 83cd9ba into QuantEcon:main May 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants