Skip to content

[inflation_history] FIX: compat with Google Colab #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2024
Merged

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented May 8, 2024

This PR fixes compatibility for inflation_history lecture with Google Collab due to an old version of pandas. This lecture requires pandas>=2.1.4 due to the use of .map

Copy link

netlify bot commented May 8, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 397e5da
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/663b0274db969a00084d7e9b
😎 Deploy Preview https://deploy-preview-439--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmcky
Copy link
Contributor Author

mmcky commented May 8, 2024

This solution isn't particularly pretty -- but working to anaconda is our key metric for compatibility. Will think of some ways we might be able to make this less intrusive.

@mmcky mmcky marked this pull request as ready for review May 8, 2024 04:26
Copy link

github-actions bot commented May 8, 2024

@github-actions github-actions bot temporarily deployed to pull request May 8, 2024 04:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 8, 2024 04:50 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented May 8, 2024

@jstac this brings compatibility with google collab. I will continue to think about cleaner ways to achieve this when we have minimum version requirements in our lectures.

@mmcky
Copy link
Contributor Author

mmcky commented May 9, 2024

@jstac I will merge this for now but I have it in my mind to figure out a cleaner solution.

@mmcky mmcky merged commit 1d2633d into main May 9, 2024
6 checks passed
@mmcky mmcky deleted the manfix-colab-compat branch May 9, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant