[update_olg] Editorial updates from #434 #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is related to #434. In particular, it involves: Code: - `x=1000` to `n=1000`; - vectorize `k_grid_next` - add y labels to plot in 24.6.3 - remove duplicate codes Content - Add hyphen to 'long run growth' and '45 degree line' - firm problem to firm's problem to match with the title - interest rate to gross interest rate to match with the content later - change $\ell_t w_t$ to $w_t \ell_t$ to match the order with $\R_t k_t$
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- fix error in previous commit
mmcky
reviewed
May 8, 2024
mmcky
reviewed
May 8, 2024
| k_grid_next = np.empty_like(k_grid) | ||
|
|
||
| for i in range(x): | ||
| for i in range(n): |
There was a problem hiding this comment.
Hi @mmcky, in the exercise, we define k_update again as follows,
def k_update(k, model):
return optimize.newton(lambda k_prime: f(k_prime, k, model), 0.1)but this time, the k_update function is not inherently vectorized as in the main text, which is
def k_update(k, α, β):
return β * (1 - α) * k**α / (1 + β)So we cannot use the way in the main text to vectorize k_grid_next.
Best,
Longye
|
thanks @longye-tian just had a few questions above. |
|
@jstac this looks ready for your review. |
|
Nice work @longye-tian , many thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear John @jstac ,
I have updated the lecture on OLG model (olg.md) according to the editorial suggestions #434. In particular, this pull request update:
Code:
x=1000ton=1000;k_grid_nextContent
Add hyphen to 'long run growth' and '45 degree line'
firm problem to firm's problem to match with the title
interest rate to gross interest rate to match with the content later
change$\ell_t w_t$ to $w_t \ell_t$ to match the order with $R_t k_t$
Best ❤️
Longye