[cobweb] Update editorial suggestions #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mmcky
reviewed
May 7, 2024
lectures/cobweb.md
Outdated
| - If $ g $ hits the 45 degree line at $p_t$, then we have $ p_{t+1} = p_t $, so $ p_t $ is a steady state. | ||
| - If $ g $ lies above the 45-degree line at $p_t$, then we have $ p_{t+1} > p_t $. | ||
| - If $ g $ lies below the 45-degree line at $p_t$, then we have $ p_{t+1} < p_t $. | ||
| - If $ g $ hits the 45-degree line at $p_t$, then we have $ p_{t+1} = p_t $, so $ p_t $ is a {ref}` steady state <scalar-dynam:steady-state>`. |
There was a problem hiding this comment.
Is this steady state link required here or is the steady state terminology clearly understood in this context?
mmcky
reviewed
May 7, 2024
lectures/cobweb.md
Outdated
| @@ -326,21 +326,21 @@ m = Market() | |||
| plot45(m, 0, 9, 2, num_arrows=3) | |||
| ``` | |||
|
|
|||
| The plot shows the function $g$ defined in {eq}`def_g` and the $45$ degree line. | |||
| The plot shows the function $g$ defined in {eq}`def_g` and the $45\degree$ line. | |||
There was a problem hiding this comment.
@SylviaZhaooo this syntax is causing the pdf builder to fail
! Emergency stop.
l.24065 ...ation:cobweb:def_g} and the \(45\degree
\) line.
|
Thanks for pointing out the issue. |
|
thanks @SylviaZhaooo @jstac this is ready for your review. |
jstac
reviewed
May 8, 2024
jstac
reviewed
May 8, 2024
|
thanks for the updates @HumphreyYang @jstac this is now ready for final review. |
mmcky
reviewed
Jun 28, 2024
Co-authored-by: Matt McKay <mmcky@users.noreply.github.com>
|
Many thanks @SylviaZhaooo ! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve comments in #433