[scalar_dynamic] Update editorial suggestions #430
Conversation
This updates the editorial suggestion in #426 (Delete %matplotlib inline) - If $n$ is an integer -> if $n$ is a positive integer - Change the duplicated heading for 22.2.3. Dynamic systems. - Capitalize the first letter in the section headings. - where $a, b$ are fixed constants -> where $a, b$ are constants. Sometimes they are referred to as parameters - $t \geq 0$ -> t = 0, 1, 2 - Arbitrary $t$ to non-negative integer $t$ - For example, recall how we [previously studied](https://python-programming.quantecon.org/python_oop.html#example-the-solow-growth-model) -> For example, in the simple Solow-Swan growth model. - $k$ is capital stock -> $k$ is capital stock per capita - a fixed dynamic system consisting -> a dynamic system consisting - Use commas instead of full stops below the sentence: "For example, for the linear model $x_{t+1} = a x_t + b$, you can use the definition to check that" - 45 degree -> 45-degree ## Code - Add labels to axis in `plot45` function x_t and x_{t+1} - Put the global variables into function $g$ - Missing full stop in 'study the trajectories' - Change the Solow model to Solow-Swan model
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks @longye-tian, much appreciated! This all looks good to me. @mmcky , could you please guide this through the merge process and close any relevant issues? |
|
thanks @longye-tian this code cell is not executing in due to a key error KeyError�'t+1' |
lectures/scalar_dynam.md
Outdated
| @@ -340,6 +335,8 @@ def plot45(g, xmin, xmax, x0, num_arrows=6, var='x'): | |||
| fig, ax = subplots() | |||
| ax.set_xlim(xmin, xmax) | |||
| ax.set_ylim(xmin, xmax) | |||
| ax.set_xlabel(r'${}_t$'.format(var), fontsize=14) | |||
| ax.set_ylabel(r'${}_{t+1}$'.format(var), fontsize=14) | |||
There was a problem hiding this comment.
@longye-tian this is causing the execution error. It almost seems like python is trying to use t+1 as a variable?
There was a problem hiding this comment.
Hi @mmcky, yes. I fix this by changing the format. I think now we can run it as we want.
There was a problem hiding this comment.
Thank you for pointing this out!
fix y_label format problem in plot45
|
@longye-tian do you have any time to work on these comments? |
Hi @mmcky , I can work on these comments as well :)) I think the other comments in #426 require a separate pull request. I will create a new pull request for other comments. Best, |
|
thanks @longye-tian -- @jstac this PR is ready for review. |
|
Many thanks @longye-tian , much appreciated. Merging. |
Dear John @jstac,
This pull request updates the editorial suggestion in #426. The details are shown as follows.
(Delete %matplotlib inline)
plot45function x_t and x_{t+1}Best ❤️
Longye