Skip to content

[olg] use function #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2023
Merged

[olg] use function #320

merged 1 commit into from
Nov 17, 2023

Conversation

shlff
Copy link
Member

@shlff shlff commented Nov 16, 2023

Hi @jstac this PR fix #317 .

@shlff shlff added the in-work label Nov 16, 2023
Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit ef2b15d
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/655602d464a4fd0008dd85f6
😎 Deploy Preview https://deploy-preview-320--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@jstac
Copy link
Contributor

jstac commented Nov 16, 2023

Thanks @shlff, this looks like a good change. Could you or @mmcky please look into the failing build and see what's happening? Maybe a link that's now broken?

@jstac
Copy link
Contributor

jstac commented Nov 16, 2023

Actually it looks like all PRs are failing to build. Could someone please put in a fix @mmcky @shlff @HumphreyYang ?

@mmcky
Copy link
Contributor

mmcky commented Nov 16, 2023

@jstac it is just the link checker -- it only runs the first time a PR runs and has flagged a couple of links. I have asked @HengchengZhang to take a look.

Previews are generating so this can be merged when you're ready.

@jstac
Copy link
Contributor

jstac commented Nov 17, 2023

Thanks @shlff and @mmcky

@jstac jstac merged commit 47c0baf into main Nov 17, 2023
@jstac jstac deleted the olg_code branch November 17, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[olg] modify code
3 participants