Review linear_equations
#263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jstac
reviewed
Jul 5, 2023
jstac
reviewed
Jul 5, 2023
jstac
reviewed
Jul 5, 2023
jstac
reviewed
Jul 5, 2023
jstac
reviewed
Jul 5, 2023
jstac
reviewed
Jul 5, 2023
jstac
reviewed
Jul 5, 2023
jstac
reviewed
Jul 5, 2023
jstac
reviewed
Jul 5, 2023
jstac
reviewed
Jul 5, 2023
|
Thanks @HengchengZhang , please see the reqeuested changes. |
|
Hi @jstac, I've applied the requested changes. There are also some minor updates. |
Change "GPD" to "GDP"
Smit-create
reviewed
Jul 18, 2023
|
@HengchengZhang would you mind resolving the conflicts and then letting me know when this is good to go? |
|
Hi @mmcky, I've resolved the conflicts and it should be good to go now. |
mmcky
reviewed
Aug 7, 2023
|
@HengchengZhang just before I merge this -- can you add the |
Change "GPD" to "GDP"
Hi @mmcky I put them back in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jstac, this PR applies the updates to
linear_equationslectures.Also thanks @DiaPorntipa and @orectique for the work done together, I've applied all the changes necessary so please have a look if you think there's still other changes needed.