This repository was archived by the owner on Jul 12, 2020. It is now read-only.
Start breaking EditingSession down into EditingActions #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beberlei
added a commit
that referenced
this pull request
Jan 9, 2014
Start breaking EditingSession down into EditingActions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the start of refactoring
EditingSession.Before continuing I'd like to know if you are happy with what I have done and what things I need to change.
One thing I'm not sure about is the location of
IndentationDetector, maybe it should be inServicesinstead ofModel?Also I think it would be sensible to adopt using
LineCollection(maybe rename it toLines?) throughout the code base where ever string arrays of lines of code are passed into methods. In this case it would make sense forLine,LineCollectionandIndentingLineCollectionto exist in a more generic namespace thanQafooLabs\Refactoring\Domain\Model. Thoughts and suggestions?I look forward to some feedback.