Skip to content
This repository was archived by the owner on Jul 12, 2020. It is now read-only.

Add autoreading of the refactored code #44

Merged
merged 1 commit into from
Dec 8, 2013

Conversation

tomphp
Copy link
Contributor

@tomphp tomphp commented Dec 8, 2013

Got the the buffer reloading. Next I guess it's to try and get it working without going to the console and requesting pressing enter.

I've also just realised there's a bug where it doesn't work properly if the file being refactorred isn't in the cwd, I'll see if I can work this out tomorrow. Maybe need to work out -p command for patch.

beberlei added a commit that referenced this pull request Dec 8, 2013
Add autoreading of the refactored code
@beberlei beberlei merged commit 51a2d80 into QafooLabs:master Dec 8, 2013
@beberlei
Copy link
Contributor

beberlei commented Dec 8, 2013

I get errors of the kind patch: **** Only garbage was found in the patch input. when applying this.

I marked 3 lines in visual, pressed ",rem" and entered a method name to get this.

@beberlei
Copy link
Contributor

beberlei commented Dec 8, 2013

@tomphp ah sorry, my refactor command is available through another name. Works out

@beberlei
Copy link
Contributor

beberlei commented Dec 8, 2013

@tomphp Why does it work for you without adding -p1 to patch cmd? It asks me for the file name... because of the a/ and b/ prefixes.

@tomphp
Copy link
Contributor Author

tomphp commented Dec 8, 2013

@beberlei yes it would appear that it needs the -p1 option. For some strange reason it was working for me but only for files in the cwd. Adding -p1 has fixed it but still not sure it why it was working for me. Do you want to add the -p to the patch command or shall I create another PR?

@beberlei
Copy link
Contributor

beberlei commented Dec 8, 2013

Already comitted it, see a809007

@tomphp
Copy link
Contributor Author

tomphp commented Dec 9, 2013

@beberlei Great :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants